Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5876: Bug: Vertical button card image overlays content in preceding color band #1649

Merged

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Oct 7, 2024

READY FOR REVIEW

Summary

Refactoring the Vertical Button Card to fix issues of the card image overlaying content

Need Review By (Date)

10/10

Urgency

high

Steps to Test

  1. On Colorful create a Flexible page
  2. Add a Colorband component and then a Collection component with 3 Vertical Button Cards per row (Only 1 with an image please)
  3. Save it and verify the Image doesn't overlay content in preceding color band
  4. Now go to /components/collections/collections-postcards/vertical-button-cards-0 on Colorful and /components/collections-0/collections-postcards/vertical-button-cards on Traditional
  5. Please verify everything looks as expected

PR Checklist


@mariannuar mariannuar self-assigned this Oct 7, 2024
@ahughes3 ahughes3 temporarily deployed to Tugboat October 7, 2024 17:15 Destroyed
@mariannuar mariannuar requested a review from cienvaras October 7, 2024 17:32
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar LGTM! 🚀

@ahughes3 Ready for your review.

@cienvaras cienvaras requested a review from ahughes3 October 8, 2024 17:29
@cienvaras cienvaras assigned ahughes3 and unassigned mariannuar Oct 8, 2024
@ahughes3 ahughes3 assigned joegl and unassigned ahughes3 Oct 9, 2024
@ahughes3 ahughes3 requested a review from joegl October 9, 2024 19:38
@joegl joegl merged commit 17eaa5b into 11.3.1-release Oct 9, 2024
17 checks passed
@joegl joegl deleted the shs-5876-fix-bug-image-overlays-in-vertical-button-card branch October 9, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants